Make a one-to-one association between a Context and a TermManager #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ozdemir
approved these changes
May 1, 2025
|
Hi @daniel-larraz, with these changes the PR #106 became obsolete due to it relying on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cvc5 recently stopped using a singleton TermManager (see cvc5/cvc5#11816). As a consequence, the Pythonic API broke, since it relied on this behavior. This PR fixes the issue by establishing a one-to-one association between a
Contextand aTermManager, ensuring that eachContexthas its ownTermManagerand that every object uses the correctContext.