This repository was archived by the owner on Dec 16, 2019. It is now read-only.
Don't modify creation date when editing bookmark via api#10
Open
pascalfree wants to merge 2 commits intocweiske:masterfrom
Open
Don't modify creation date when editing bookmark via api#10pascalfree wants to merge 2 commits intocweiske:masterfrom
pascalfree wants to merge 2 commits intocweiske:masterfrom
Conversation
Owner
|
Good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
When changing a bookmark with the API, the only way to do this is via
posts/add?replace=yes&....When editing a bookmark the expected behaviour is, that the creation date is unchanged and the modification date will change.
Currently both dates are changed when using the api function. A workaround would be to send a date
dt=..., but then the modification date is not accurate, it will be set to the same date as the new creation date.With this pull request, when
replace=yesis set, the bookmark will be "updated" and thedtoption will be ignored. This is compatible to the delicious api.I wrote a test for that, which passed in my setup.
I'm creating a new pull request for this (instead of using #9) because, this seems like a bug, that should be fixed in the current api.
I will fix it in the new api as well.