Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill tasks during job prep. #5749

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Sep 30, 2023

Close #5746

This PR allows cylc kill to abort jobs that are in the job preparation pipeline, resulting in the submit-failed state.

To avoid dealing with the complexities of partial job preparation, I've take the following approach:

  • the kill command sets a flag in preparing task proxies
  • the job submission process aborts at the last minute, after preparation has completed
  • (so retriggering the task will result in a new submit number).

Tested by deliberately extending job preparation like this (and kill tasks whilst still in the preparing state)

platform = $(sleep 10; echo localhost)

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver self-assigned this Oct 3, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.4.0 milestone Feb 19, 2024
@MetRonnie
Copy link
Member

MetRonnie commented Nov 12, 2024

After discussing removing a preparing task with Oliver (for #6472), this will probably be even more important as the task might end up submitting and running outside of the task pool if not killed? Not sure, haven't tested yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kill should abort preparing tasks
3 participants