Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UTC mode from tutorial workflows #6454

Open
wants to merge 1 commit into
base: 8.3.x
Choose a base branch
from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 29, 2024

UTC mode is a legacy setting which isn't required any-more for tutorial workflows.

Companion of cylc/cylc-doc#769

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are not included should be tested by the validate script.
  • Changelog entry not included - very small change
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • PR raised against bug fix branch because this is a doc-fix and not a feature.

@wxtim wxtim self-assigned this Oct 29, 2024
@wxtim wxtim added small doc Documentation labels Oct 29, 2024
@wxtim wxtim added this to the 8.3.7 milestone Oct 29, 2024
@oliver-sanders
Copy link
Member

@wxtim
Copy link
Member Author

wxtim commented Oct 29, 2024

I think the UTC mode default is still False?

https://cylc.github.io/cylc-doc/stable/html/reference/config/global.html#global.cylc[scheduler]UTC%20mode

It is, but it no longer has any effect on the cycle point time zone (Old docs) so it doesn't matter any more.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if it's just about the logging format.

Make sure it doesn't appear in any examples in cylc-doc if removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants