broadcast: report invalid settings #6574
Open
+252
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
6429
branch
2 times, most recently
from
b111fc7 to
3c02de1
Compare
* We already report invalid cycle points and namespaces. * However, we have been relying on client-side validation for settings (which doesn't apply to the GraphQL mutation). * This also raises the potential for inter-version compatibility issues going unreported. * This commit explicitly handles invalid settings in the same way as invalid cycle points and namespaces so that they are reported back to the user. * Closes the issue part of cylc#6429. * Additionally: * This change also strips duplicate entries from broadcast reports. * And fixes the CLI options in broadcast report to match `cylc broadcast`.
|
Note to self, if #6554 is merged before this, change the code to return the invalid broadcast to the user rather than just logging it server side: |
6554 has been merged. |
wxtim
reviewed
Mar 11, 2025
Comment on lines
+59
to
+63
| ret = [] | ||
| for item in iterable: | ||
| if item not in ret: | ||
| ret.append(item) | ||
| return ret |
There was a problem hiding this comment.
If you do this you can also do away with a bit of the documentation too: There's no point having the same doctest for both functions.
Suggested change
| ret = [] | |
| for item in iterable: | |
| if item not in ret: | |
| ret.append(item) | |
| return ret | |
| return list(iter_uniq(iterable)) |
There was a problem hiding this comment.
(note, this is a code move from the resolvers module)
I suspect it's probably more efficient to build a list directly, than to build a set, then build a list from the set.
wxtim
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broadcast: report invalid settings
cylc broadcast.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.