Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some warnings #6640

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Address some warnings #6640

wants to merge 4 commits into from

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 27, 2025

Spotted in pytest output

datetime.utcnow()

Deprecated since version 3.12: Use datetime.now() with UTC instead.

Note

There is a risk with this because using comparison operators (e.g. <) between timezone-aware and naive (timezone-unaware) datetimes results in a type error. However I do not think we are doing any such comparisons, and all the tests are passing.

sqlite3.connect():

Changed in version 3.13: Positional use of the parameters timeout, detect_types, isolation_level, check_same_thread, factory, cached_statements, and uri is deprecated. They will become keyword-only parameters in Python 3.15.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • No tests/docs/changelog needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the 8.5.0 milestone Feb 27, 2025
@MetRonnie MetRonnie self-assigned this Feb 27, 2025
@oliver-sanders
Copy link
Member

oliver-sanders commented Mar 4, 2025

@hjoliver, this PR removes a code block that isn't used any more. Can you have a quick look at it and merge if ok.

@oliver-sanders oliver-sanders requested a review from hjoliver March 4, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants