actions: provision python from conda-forge #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
oliver-sanders
force-pushed
the
actions.micromamba
branch
3 times, most recently
from
a717fa0 to
c3e23d2
Compare
MetRonnie
reviewed
Mar 6, 2025
Comment on lines
82
to
+90
| - name: 'macos 1/5' | ||
| os: 'macos-latest' | ||
| python-version: '3.9' | ||
| python-version: '3.8' # oldest available | ||
| test-base: 'tests/f' | ||
| chunk: '1/5' | ||
| platform: '_local_background*' | ||
| - name: 'macos 2/5' | ||
| os: 'macos-latest' | ||
| python-version: '3.9' | ||
| python-version: '3' # newest available |
There was a problem hiding this comment.
The original intention was to run the 1/4 chunk in MacOS on the oldest Python version. (However at some point this was split into 1/5 and 2/5 for faster completion.)
What is the intention behind running different chunks in different Python versions?
There was a problem hiding this comment.
I thought we should probably have a test for latest Python on Mac OS as a canary. Happy to revert (unrelated really).
oliver-sanders
force-pushed
the
actions.micromamba
branch
from
c3e23d2 to
f1dee5a
Compare
oliver-sanders
commented
Mar 6, 2025
Comment on lines
+160
to
+163
| sudo apt-get update | ||
| sudo apt-get install -y at |
There was a problem hiding this comment.
at is the one thing we need to get from the OS package manager.
oliver-sanders
commented
Mar 6, 2025
| @@ -12,6 +12,10 @@ concurrency: | |||
| group: ${{ github.workflow }}-${{ github.ref }} | |||
| cancel-in-progress: true | |||
|
|
|||
| defaults: | |||
| run: | |||
| shell: bash -c "exec $CONDA_PREFIX/bin/bash -elo pipefail {0}" | |||
There was a problem hiding this comment.
Setting -eo pipefail for error checking.
MetRonnie
reviewed
Mar 11, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
* Install system dependencies from conda-forge rather than relying on the OS package manager. * This divorces us from the system environment / underlying OS image, isolating us from changes to it. * This gives us more flexibility in the versions of the systems we install (e.g. no need to change OS image to install an older/newer version of Python).
* Closes cylc#6630 * Fixes SQL statements in functional tests to recent changes in sqlite3.
* Remove trailing newline character from SCP command.
oliver-sanders
force-pushed
the
actions.micromamba
branch
from
f1dee5a to
f467a07
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
* We were adding the `mail` command to `$PATH` in the `~/.bashrc` file, however, this file returns early when not run in interactive mode (which is always in a CI environment). * Moved this into the `~/.bash_profile` file.
|
Ok, comments addressed:
|
MetRonnie
approved these changes
Mar 11, 2025
oliver-sanders
commented
Mar 11, 2025
Co-authored-by: Ronnie Dutta <[email protected]>
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apt get(toat) and remove usagebrew installcompletely.svntests aren't skipped.mailcommand to ensure mail tests aren't skipped.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.