Skip to content

resolvers: catch object leak #6985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

resolvers: catch object leak #6985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cylc/flow/network/resolvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,8 @@ async def subscribe_delta(
del delta_queues[w_id][sub_id]
if sub_id in self.delta_store:
del self.delta_store[sub_id]
if sub_id in self.delta_processing_flows:
del self.delta_processing_flows[sub_id]
Comment on lines +632 to +633
Copy link
Member Author

@oliver-sanders oliver-sanders Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwsutherland, do you know if it makes sense to delete the entry here or should be cleared elsewhere in the code?

Copy link
Member Author

@oliver-sanders oliver-sanders Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwsutherland, any ideas on how this dict was intended to be housekept?

Copy link
Member

@dwsutherland dwsutherland Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that makes sense.

yield None

async def flow_delta_processed(self, context, op_id):
Expand Down
Loading