Fix icp = now changing on reload #7048
Open
+189
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Oct 17, 2025
|
|
||
| # Store raw initial cycle point in the DB. | ||
| value = schd.config.evaluated_icp | ||
| value = None if value == 'reload' else value |
There was a problem hiding this comment.
Initial cycle point cannot be "reload" (#4313)
MetRonnie
force-pushed
the
icp-nonsense
branch
from
1dc3009 to
992d335
Compare
…does not change on reload vs start
MetRonnie
force-pushed
the
icp-nonsense
branch
from
992d335 to
4d96fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7047
Follow-up to #6316
Built upon:
--startcpoption #7024Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.