job log retrieval: configurable success condition #7052
+177
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
commented
Oct 21, 2025
oliver-sanders
commented
Oct 21, 2025
| return | ||
|
|
||
| try: | ||
| host = get_host_from_platform(platform, bad_hosts=self.bad_hosts) |
There was a problem hiding this comment.
Split this try block into two so tools like mypy can tell that platform cannot be undefined.
(see the before part of the diff)
oliver-sanders
force-pushed
the
job-log-retrieval.configurable-success-condition
branch
from
37103d6 to
5aae063
Compare
oliver-sanders
changed the title
oliver-sanders
force-pushed
the
job-log-retrieval.configurable-success-condition
branch
from
5aae063 to
41c1e9d
Compare
|
Converted to draft as a newly added feature (#6933) needs to be updated in response to this.... ... done |
oliver-sanders
force-pushed
the
job-log-retrieval.configurable-success-condition
branch
from
41c1e9d to
47ce08f
Compare
oliver-sanders
commented
Oct 30, 2025
Comment on lines
+589
to
+597
| job_log_present = all( | ||
| (Path(local_log_dir) / file).exists() | ||
| for file in [ | ||
| # the files which are used to indicate that job log retrieval | ||
| # has completed | ||
| 'job.out', | ||
| *platform['retrieve job log expected files'], | ||
| ] | ||
| ) |
There was a problem hiding this comment.
With this PR, the condition we use to determine whether job log retrieval has completed can also take into account these configured files. The cylc cat-log logic should also respect this.
* Presently, job log retrieval is considered successful when the `job.out` file appears, and additionally the `job.err` file if the job failed. * This commit adds a new configuration to allow additional files to be specified. * This will help with a MO platform where the job epilogue file is written asynchronously, so may only appear some time after the `job.out` file.
oliver-sanders
force-pushed
the
job-log-retrieval.configurable-success-condition
branch
from
47ce08f to
0766817
Compare
MetRonnie
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
job.outfile appears, and additionally thejob.errfile if the jobfailed.
specified.
written asynchronously, so may only appear some time after the
job.outfile.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.