Skip to content

pause: fix trigger whilst paused logic #7054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 8.6.x
Choose a base branch
from
Open

pause: fix trigger whilst paused logic #7054

wants to merge 1 commit into from

Conversation

@oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 22, 2025 •
edited
Loading

I think this one is fairly simple, just a subtle error.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.6.1 milestone Oct 22, 2025
@oliver-sanders oliver-sanders self-assigned this Oct 22, 2025
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Oct 22, 2025
hjoliver
hjoliver approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, yes - good spotting.

@oliver-sanders oliver-sanders force-pushed the 7016 branch 2 times, most recently from fc3d7d4 to 47da103 Compare October 30, 2025 14:08
@oliver-sanders
pause: fix trigger whilst paused logic
f7dfd08 
* Closes cylc#7016
* The wrong indicator was being used to list tasks for job preparation
  resulting in duplicate preparation calls.
@oliver-sanders oliver-sanders requested a review from wxtim November 5, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim Awaiting requested review from wxtim

Assignees

@oliver-sanders oliver-sanders

Labels

bug Something is wrong :(

Projects

None yet

Milestone

8.6.1

Development

Successfully merging this pull request may close these issues.

2 participants

@oliver-sanders @hjoliver