Skip to content

polling: reset bad hosts on manual poll #7055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 8.6.x
Choose a base branch
from
Open

polling: reset bad hosts on manual poll #7055

wants to merge 1 commit into from
+103 −14

Conversation

@oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Oct 22, 2025

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.6.x milestone Oct 22, 2025
@oliver-sanders oliver-sanders self-assigned this Oct 22, 2025
@oliver-sanders oliver-sanders added the could be better Not exactly a bug, but not ideal. label Oct 22, 2025
@oliver-sanders oliver-sanders modified the milestones: 8.6.x, 8.6.1 Oct 22, 2025
@oliver-sanders oliver-sanders mentioned this pull request Oct 22, 2025
Open
@oliver-sanders
polling: reset bad hosts on manual poll
f42efd0 
* Closes cylc#7029
* This reduces the pressure on cylc#7001 (polling is not attempted if a
  platform runs out of hosts until the next run of reset-bad hosts) by
  making it easier for operators to reset bad hosts and recover their
  workflow in the event of platform outages.
MetRonnie
MetRonnie reviewed Nov 4, 2025
View reviewed changes
cylc/flow/task_job_mgr.py
Comment on lines +997 to +1008
if continue_if_no_good_hosts:
# no hosts available for this platform
# -> reset the bad hosts and try again
self.task_events_mgr.reset_bad_hosts()
host = get_host_from_platform(
platform, bad_hosts=self.bad_hosts
)
else:
ctx.err = f'No available hosts for {platform["name"]}'
LOG.debug(ctx)
callback_255(ctx, itasks)
continue
Copy link
Member

@MetRonnie MetRonnie Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both branches here continue to the next iteration of the for loop. host is not used in the first branch. Did you mean to remove the else condition on the line below?

Copy link
Member

@wxtim wxtim Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mildly concerned that if Ronnie is right (I think he is) that the test isn't failing....

wxtim
wxtim reviewed Nov 4, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wxtim wxtim wxtim left review comments

@MetRonnie MetRonnie MetRonnie left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@oliver-sanders oliver-sanders

Labels

could be better Not exactly a bug, but not ideal.

Projects

None yet

Milestone

8.6.x

Development

Successfully merging this pull request may close these issues.

3 participants

@oliver-sanders @wxtim @MetRonnie