Skip to content

Commit

Permalink
Suggested change to warning text re integers starting with a zero (#255)
Browse files Browse the repository at this point in the history
* Suggested change to warning text when integers with leading zeros are found in the cylc workflow definition.

* Apply suggestions from code review

Co-authored-by: Tim Pillinger <[email protected]>

---------

Co-authored-by: Oliver Sanders <[email protected]>
Co-authored-by: Tim Pillinger <[email protected]>
  • Loading branch information
3 people authored Oct 5, 2023
1 parent b4ba1a2 commit 545bdb1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ below.
- Mel Hall
- Bruno Kinoshita
- Hilary Oliver
- Jonny Williams
<!-- end-shortlog -->

(All contributors are identifiable with email addresses in the git version
Expand Down
7 changes: 4 additions & 3 deletions cylc/rose/jinja2_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,11 @@ def patch_jinja2_leading_zeros():
if jinja2.lexer.Lexer.wrap._instances:
num_examples = 5
LOG.warning(
'Support for integers with leading zeros was dropped'
' in Jinja2 v3.'
'Support for integers with leading zeros (including'
' lists of integers) was dropped in Jinja2 v3.'
' Rose will extend support until a future version.'
'\nPlease amend your Rose configuration files e.g:'
'\nPlease amend your Rose configuration files,'
' which currently contain:'
'\n * '
+ (
'\n * '.join(
Expand Down

0 comments on commit 545bdb1

Please sign in to comment.