Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if "=" not in define #226

Closed
wxtim opened this issue May 5, 2023 · 0 comments · Fixed by #225
Closed

Error if "=" not in define #226

wxtim opened this issue May 5, 2023 · 0 comments · Fixed by #225
Assignees
@wxtim
Labels
small
Milestone
1.3.1

Comments

@wxtim
Copy link
Member

wxtim commented May 5, 2023

Replaces metomi/rose#2691

If a user were to make a typo and do

CYLC_VERSION=7 rose suite-run -D 'FOO42'
# or
CYLC_VERSION=8 cylc vip -D 'FOO42'

No warning or error is raised despite this define being largely meaningless.

Should we warn when defines are not in the form [section]key=value or key=value?
This was referenced May 5, 2023
Closed
Merged
@MetRonnie MetRonnie changed the title Error if "=" not in define Error if "=" not in define May 5, 2023
@wxtim wxtim linked a pull request Jun 29, 2023 that will close this issue
Raise error if "=" not in define #225
Merged
8 tasks
@wxtim wxtim modified the milestones: 1.3.0, 1.2.1 Jun 29, 2023
@wxtim wxtim added the small label Jun 29, 2023
@oliver-sanders oliver-sanders modified the milestones: 1.2.1, 1.3.1 Jul 17, 2023
@wxtim wxtim closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

Raise error if "=" not in define wxtim/cylc-rose
2 participants
@oliver-sanders @wxtim