-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error if "="
not in define
#225
Raise error if "="
not in define
#225
Conversation
9067608
to
5067143
Compare
Wrong Issue number? [link was dead] |
"=" not in define
I originally wrote this up as a rose issue (because it seems like a rose problem). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor questions.
cylc/rose/utilities.py
Outdated
|
||
if match['state'] in ['!', '!!']: | ||
LOG.warning( | ||
'CLI opts set to ignored or trigger-ignored will be ignored.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that a thing? (Use the ignore syntax on the command line?) Why would anyone do that? And if they do do it, should it need a warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that a thing? (Use the ignore syntax on the command line?) Why would anyone do that?
@oliver-sanders - Like Hilary, I have no idea why anyone would do this - do you know?
And if they do do it, should it need a warning?
There's already a warning in the post install entry point, and perhaps it only needs to be there if it's only a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a "thing", in Rose ignored items still exist in the configuration, just with a different state so could still be functional in some strange way. A good example of this is the opts
config in the rose-suite-cylc-install.conf
file which is marked as ignored (for clarity because opts are not functional when defined in optional configs) but this value is used by the cylc-rose plugin to cylc reinstall
so is functional.
I don't think we need a warning here, you'd have to go out of your way to add an ignored config, if you do we can only assume you know what you're doing.
This comment was marked as resolved.
This comment was marked as resolved.
29256a6
to
7e5414f
Compare
8c4e015
to
bcfc149
Compare
bcfc149
to
5d4d389
Compare
…wxtim/cylc-rose into feature.do_not_allow_--defines_no_equal * 'feature.do_not_allow_--defines_no_equal' of github.com:wxtim/cylc-rose: Ensure that a `:suite.rc` is added to the template language when creating defines.
Closes #226
Built atop #221
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect usersNo documentation update req'd?.?.x
branch.