Changed the rose stem functional tests to a more pytest-integration s… #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
convert_subprocess_functional_tests_to_pure_python
branch
from
a7ca960
to
6431826
Compare
MetRonnie
reviewed
Oct 3, 2022
There was a problem hiding this comment.
Coverage up 20%: https://app.codecov.io/gh/cylc/cylc-rose/pull/188
But we're not getting the status here on GitHub. I think @hjoliver might be the only one who can enable the CodeCov app for the repo?
Edit: also on cylc-uiserver
…tyle. rose_stem_cmd ⇒ rose_stem_opts
wxtim
force-pushed
the
convert_subprocess_functional_tests_to_pure_python
branch
from
d908f7c
to
3378b0f
Compare
MetRonnie
approved these changes
Oct 4, 2022
datamel
approved these changes
Oct 10, 2022
|
IMO both, as it's just tests that have been affected |
|
Let's get it into 1.2.0 as it is raised on master. No real need to backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tyle.
By separating the command line script into a parser and a rose_stem function I am able to import the rose_stem function and run it without subprocesses. This is good because it is both faster and recognized by codecov.
These changes partially address #157
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg.