Rejig #265
Merged
Rejig #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move utils out of the entry points module and move the rose-stem entry point in. * Move fileinstall into its own module. * Sort imports.
* `['a'].sort()` returns `None` not `['a']` * So `assert a.sort() == b.sort()` will always be `True`.
* Avoid having to handle None values for srcdir/rundir throughout the codebase by catching them earlier.
* A future rose stem interface will need to inject itself between config loading and processing. * So colocate the plugin processing logic into one function.
* Entry points accept missing or None values for arguments, however, this can never happen in practice. * Set the appropriate type hints and remove code paths which could not get executed.
* Amend false docstrings. * Rename a couple of modules.
wxtim
reviewed
Nov 2, 2023
MetRonnie
reviewed
Nov 7, 2023
Comment on lines
+485
to
+487
| opt_conf_keys: list = [] | ||
| defines: list = [] | ||
| rose_template_vars: list = [] |
There was a problem hiding this comment.
Can it be more specific? List[str]?
There was a problem hiding this comment.
Don't know the types, added the list placeholder purely to allow the function to by type checked in the first place.
MetRonnie
approved these changes
Nov 8, 2023
wxtim
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of TLC in preparation for the addition of a new rose-stem interface which needs to be bodged into the middle of an existing function.
Main changes:
point in.
this can never happen in practice.
get executed.
Minor changes:
between config loading and processing.
['a'].sort()returnsNonenot['a']assert a.sort() == b.sort()will always beTrue.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.