Exit immediately if no rose suite.conf #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have a rose-suite.conf
oliver-sanders
approved these changes
Nov 22, 2023
|
Tests are in a bit of a mess at the moment. Disregarding the 3.7 job failing on installation, there are 8 tests failing on the 3.8 job (but 5 of those are failing on master) Edit: never mind, I get 8 failures on master locally. Not sure why only 5 on GH Actions Edit edit: or sometimes 7 failures... |
|
(taking a look at the rose-stem flakeyness, they did pass on the last branch) |
|
This should stabilise the rose-stem tests: #268 |
|
The reinstall tests are broken because the interface has changed from sync to async in cylc-flow. |
MetRonnie
approved these changes
Dec 4, 2023
|
Will run tests locally... |
|
I get the same fails on master as on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make pre-configure act like post install.
Because pre-configure uses Cylc global config in the process of getting
ROSE_ORIG_HOSTit creates an instance of the global config object with the default items if it is called before the global config is otherwise instantiated, such as when loading and parsing a global config file.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).Tests are includedChange in code covered by existing tests.CHANGES.mdentry included if this is a change that can affect usersCylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.If this is a bug fix, PR should be raised against the relevant?.?.xbranch.