Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock only a single method of the rose config object. #291

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Mock only a single method of the rose config object. #291

merged 2 commits into from
Jan 25, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 25, 2024

Small change to #289 to avoid the use of mock, and to change the Rose config object as little as possible.

@wxtim wxtim added this to the 1.3.3 milestone Jan 25, 2024
@wxtim wxtim self-assigned this Jan 25, 2024
@wxtim wxtim added the small label Jan 25, 2024
@wxtim wxtim requested a review from MetRonnie January 25, 2024 15:06
@wxtim wxtim changed the title Use a real RoseConfig to avoid need to mock objects. Mock only a single method of the rose config object. Jan 25, 2024
@MetRonnie MetRonnie merged commit 1e3e97c into cylc:1.3.x Jan 25, 2024
7 checks passed
@wxtim wxtim deleted the fix.test_flake_caused_by_rose_site_config_caching branch January 25, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@wxtim wxtim

Labels
small
Projects
None yet
Milestone
1.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @oliver-sanders @MetRonnie