Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log versions of Cylc, Rose and CylcRose in the rose-suite-cylc-instal… #320

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented May 8, 2024

…l.conf

Closes #318

Also took the opportunity to move tests/unit/test_functional_post_install.py to tests/functional/test_post_install.py. This has been bugging me for ages, but I dodn't want to muddy the waters of a more complex PR.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md not changed - this is a logging change only.
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim self-assigned this May 8, 2024
@wxtim wxtim added the small label May 8, 2024
@wxtim wxtim added this to the 1.5.0 milestone May 8, 2024
@wxtim wxtim force-pushed the log_cylc_rose_version_on_install branch from dc6bbcb to e3df1d2 Compare May 8, 2024 11:53
cylc/rose/utilities.py Outdated Show resolved Hide resolved
tests/functional/test_reinstall.py Show resolved Hide resolved
tests/functional/test_reinstall.py Show resolved Hide resolved
tests/functional/test_reinstall_clean.py Show resolved Hide resolved
tests/functional/test_reinstall_clean.py Show resolved Hide resolved
@oliver-sanders
Copy link
Member

(lint failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log cylc-rose version on installation
2 participants