Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkpoint script & workflow #620

Closed
kinow opened this issue Mar 19, 2021 · 1 comment
Closed

Update checkpoint script & workflow #620

kinow opened this issue Mar 19, 2021 · 1 comment

Comments

@kinow
Copy link
Member

kinow commented Mar 19, 2021

Describe the bug

It's not possible to re-generate the current checkpoint workflow, one. The script uses cylc reg/cylc run, which will need to be replaced by cylc install/cylc play.

Furthermore, there's also an issue that recent changes to Cylc Flow (probably related to SoD or event-driven?) changed the output of the checkpoint task, which doesn't include the GOOD family anymore.

Release version(s) and/or repository branch(es) affected?

master

Steps to reproduce the bug

Run the generate script, compare with previous output that contains the GOOD family.

Expected behavior

Output similar to previous output, not necessarily identical due to #559 , but still structurally similar.

Screenshots

Additional context

This is also blocking #543 (comment) as the tests expect the GOOD family in one e2e test (one example, but there are other tests that expect the structure to be the same).

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@kinow kinow added the bug Something isn't working label Mar 19, 2021
@kinow kinow added this to the 0.3 milestone Mar 19, 2021
@kinow kinow mentioned this issue Mar 21, 2021
7 tasks
@kinow kinow self-assigned this Mar 21, 2021
@oliver-sanders oliver-sanders modified the milestones: 0.3, 0.4 Mar 25, 2021
@oliver-sanders oliver-sanders modified the milestones: 0.4.0, 0.5.0 Apr 16, 2021
@oliver-sanders oliver-sanders modified the milestones: 0.5.0, 0.6.0 Jul 28, 2021
@kinow kinow removed their assignment Aug 16, 2021
@kinow kinow modified the milestones: 0.6.0, 1.0, 2.0 Sep 10, 2021
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
@oliver-sanders
Copy link
Member

I think at this stage it looks like hand editing the offline data is the way to go.

So closing this one for now, we may re-visit auto-generating it at a future point.

@oliver-sanders oliver-sanders removed this from the Pending milestone Dec 1, 2022
@oliver-sanders oliver-sanders removed the bug Something isn't working label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants