-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checkpoint workflow one #624
Conversation
Couldn't get the succeeded state to show. We could update the tests, but it'd be best to take a better look at this workflow. Luckily @hjoliver offered to help on this issue 🙏 @oliver-sanders offered an alternative in Python that could fix the current workflow and also give a constant output to the checkpoint workflow (we updated the tests a few times in the past due to changes in the workflow output): #559 (comment) |
This is really outdated now. The fix will be either in a Python code to generate the desired data/states. Or in a Cylc 8 workflow that is able to have the succeeded state (which is hard/impossible? with spawn-on-demand) |
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
- Coverage 85.54% 76.96% -8.58%
==========================================
Files 70 48 -22
Lines 1418 1120 -298
Branches 103 84 -19
==========================================
- Hits 1213 862 -351
- Misses 178 233 +55
+ Partials 27 25 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
These changes close #620
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.