Use task icons in gscan, not job icons. #1050
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change with no associated Issue.
As discussed in Element chat, the gscan panel shows task states represented by job icons. Arguably this is a bug, even though it was deliberate, because task and jobs states are not quite the same thing even where they seemingly coincide. We apparently discussed this early in the project and decided to use job icons in gscan because:
However, the one-to-one mapping is somewhat beside the point in the case of retrying tasks, and I have evidence (a "bug" report) that users may find this confusing.
User: "gscan showed no failed tasks, but when I opened the workflow there was a failed task[sic] in it".
On this branch:
(NB the task progress bar is not relevant here, would need to get rid of that of course).
This still requires users to understand the difference between task and job icons, but unlike in the first case it is not potentially confusing once you do understand that.
So IMO we should change this. If others are super attached to a colourful gscan, we should consider making that a user preference (next to which we can document the failed job retrying task "subtlety" that results).
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.