Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency utf-8-validate to v6 #1195

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
utf-8-validate ^5.0.9 -> ^6.0.0 age adoption passing confidence

Release Notes

websockets/utf-8-validate

v6.0.1

Compare Source

v6.0.0

Compare Source

v5.0.10

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 10, 2023
@oliver-sanders
Copy link
Member

Is this dev dependency used?

@oliver-sanders oliver-sanders added this to the 1.5.0 milestone Jan 18, 2023
@MetRonnie
Copy link
Member

MetRonnie commented Jan 23, 2023

Added in e993c83#r481447212

When removed I get a build warning when running the unit tests

 WARNING  Compiled with 1 warning
 warning  in ./node_modules/subscriptions-transport-ws/node_modules/ws/lib/validation.js
Module not found: Error: Can't resolve 'utf-8-validate' in '~/github/cylc-ui/node_modules/subscriptions-transport-ws/node_modules/ws/lib'

 WEBPACK  Compiled with 1 warning(s)
Warning in ./node_modules/subscriptions-transport-ws/node_modules/ws/lib/validation.js
  Module not found: 'utf-8-validate' in '~/github/cylc-ui/node_modules/subscriptions-transport-ws/node_modules/ws/lib'

Presumably it can be removed when #1028 is tackled. Or if we are happy to live with the warning, we could remove it now?

@oliver-sanders oliver-sanders merged commit 6d1a589 into master Jan 23, 2023
@renovate renovate bot deleted the renovate/utf-8-validate-6.x branch January 23, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants