Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ESLint no-console & move Cypress component tests to tests/ dir #1803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Re-enable ESLint no-console & move Cypress component tests to tests/ dir #1803

wants to merge 2 commits into from

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented May 20, 2024 •
edited
Loading

  • Re-enable no-console ESLint rule for console.log() and console.debug()
    • This was seemingly accidentally lost at some point
    • Left it off for console.warn() and console.error() as we do that often enough
  • Move Cypress component tests into tests/ dir for consistency with E2E tests

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).

@MetRonnie MetRonnie self-assigned this May 20, 2024
@MetRonnie MetRonnie added this to the 2.6.0 milestone May 20, 2024
@MetRonnie MetRonnie requested review from wxtim and removed request for markgrahamdawson August 22, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

Assignees

@MetRonnie MetRonnie

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MetRonnie @wxtim