Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly defining toolbar items. #1945

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

ChrisPaulBennett
Copy link
Contributor

@ChrisPaulBennett ChrisPaulBennett commented Sep 24, 2024

Fix issue raised in #1944

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

Changes download tooltip
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does the trick for the Gantt View, however, the download button for the "box & whiskers" chart in the Analysis View still has the tooltip "Menu". The "time series chart" doesn't seem to have a download button.

@ChrisPaulBennett ChrisPaulBennett self-assigned this Oct 1, 2024
@ChrisPaulBennett
Copy link
Contributor Author

Added the changes to the box plot and time series.
FYI, you need to select some variables in the time series before the download button shows up

@oliver-sanders oliver-sanders merged commit cb48e1e into cylc:master Oct 1, 2024
8 checks passed
@oliver-sanders oliver-sanders added this to the 2.6.0 milestone Oct 1, 2024
@oliver-sanders oliver-sanders added the UX/UI User experience and interface improvements label Oct 1, 2024
@ChrisPaulBennett ChrisPaulBennett deleted the gantt-tooltip branch October 1, 2024 13:16
@MetRonnie MetRonnie added small data workflows team Work pertaining to the analysis/gantt/etc views labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data workflows team Work pertaining to the analysis/gantt/etc views small UX/UI User experience and interface improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants