Skip to content

chore(deps): remove outdated linting modules #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MikeMcC399
Copy link

Situation

pre-git

The npm module [email protected], configured in the repo, was released on Mar 13, 2018. This was 7 years ago and is the latest release of the module. The module is effectively unmaintained.

  • pre-git contains multiple unfixable vulnerabilities:

    16 vulnerabilities (5 moderate, 7 high, 4 critical)

  • The postinstall hook of pre-git adds a semantic-release configuration option, changing the default, if simple-commit-message has been uninstalled
      "release": {
      "analyzeCommits": "simple-commit-message"
    },

github-post-release

The npm module [email protected], configured in the repo, was released on Aug 11, 2017. This was 8 years ago and is the latest release of the module. The module is effectively unmaintained.

  • github-post-release contains multiple unfixable vulnerabilities:

    19 vulnerabilities (3 moderate, 10 high, 6 critical)

dont-crack

The npm module [email protected], configured in the repo, was released on Jun 7, 2017. This was 8 years ago and is the latest release of the module. The module is effectively unmaintained.

  • dont-crack contains multiple unfixable vulnerabilities:

    36 vulnerabilities (3 low, 12 moderate, 15 high, 6 critical)

simple-commit-message

simple-commit-message is in the dependencies section of pre-git and of github-post-releasetherefore these need to be considered together:

The npm module [email protected] configured in the repo, was released on Jul 4, 2021 and is the latest release. It is effectively unmaintained and has the following issues:

Assessment

simple-commit-message, pre-git, github-post-release and dont-crack are linting components, intended to apply rules and increase the quality of the packaged module.

Their unmaintained and vulnerable status however means that they can no longer be used. It may be possible to replace their function using supported modules, however given the number of other issues in this repo, this enhancement would need to be deferred to a later stage.

The modules are used in the configuration of semantic-release. See also #165 for separate releated configuration issues.

Since these modules are all interrelated, they need to be removed together.

Change

In package.json, remove:

Verify

On Ubuntu 24.04.2 LTS, Node.js 22.17.1 LTS

execute the following and confirm no fatal errors are reported:

npm ci
npm test
npx semantic-release --dry-run

Follow-up

Locally, it may be necessary to remove hooks from .git/hooks manually.

Remove devDependencies:
dont-crack
github-post-release
pre-git
simple-commit-message
@MikeMcC399
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant