Skip to content

Conversation

MikeMcC399
Copy link
Contributor

Change

The .github/workflows/test.yml CI workflow is updated from Node.js 20 to 22.

The Node.js release schedule shows Node.js 22.x moved to Active LTS status on Oct 29, 2024.

Framework compatibility

The repo is now configured with the following framework versions, which are all compatible with Node.js 22.x:

Framework Version Node.js requirements
Angular 19.0.3 ^18.19.1 || ^20.11.1 || ^22.0.0
React 19.0.0 -
Vite 6.0.3 ^18.0.0 || ^20.0.0 || >=22.0.0
Svelte 5.7.0 >=18
Vue 3.5.13 >=18.3

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should eventually add a .node-version file in this repo

@AtofStryker AtofStryker merged commit 1dc6caa into cypress-io:main Jan 21, 2025
4 checks passed
@MikeMcC399
Copy link
Contributor Author

@AtofStryker

we should eventually add a .node-version file in this repo

That would make a lot of sense for clarity. Would you like me to submit a PR for this?

I would also suggest to make https://github.com/actions/setup-node use node-version-file instead of hard-coding the literal Node.js version into the GitHub Actions workflow.

@MikeMcC399 MikeMcC399 deleted the update/ci-node-22 branch January 21, 2025 15:20
@AtofStryker
Copy link
Contributor

@AtofStryker

we should eventually add a .node-version file in this repo

That would make a lot of sense for clarity. Would you like me to submit a PR for this?

I would also suggest to make https://github.com/actions/setup-node use node-version-file instead of hard-coding the literal Node.js version into the GitHub Actions workflow.

If you have time that would be great!

@MikeMcC399
Copy link
Contributor Author

@AtofStryker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants