internal: (studio) add socket listeners #31470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/studio/add_socket_listener
|
| Run status |
|
| Run duration | 14m 16s |
| Commit |
|
| Committer | Matt Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
585
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
0%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
0
|
Accessibility
97.09%
|
|
|---|---|
|
Failed rules
|
0 critical
1 serious
0 moderate
0 minor
|
|
Failed elements
|
6
|
There was a problem hiding this comment.
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (2)
- packages/server/package.json: Language not supported
- packages/types/package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/server/lib/socket-base.ts:410
- [nitpick] Consider adding a test case to verify the behavior when coreData.studio is undefined to ensure addSocketListeners is not called unexpectedly.
getCtx().coreData.studio?.addSocketListeners(socket)
ryanthemanuel
approved these changes
Apr 14, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Updated
socket-baseto calladdSocketListenerson the studio manager to allow studio to add any necessary socket listeners.Steps to test
n/a
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?