-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat: prompt (WIP - do not merge) #31752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanthemanuel
wants to merge
56
commits into
develop
Choose a base branch
from
feat/cy-prompt
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,123
−474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
feat/cy-prompt
|
Run status |
|
Run duration | 19m 41s |
Commit |
|
Committer | Ryan Manuel |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
3
|
|
14
|
|
1101
|
|
4
|
|
26547
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
44.73%
|
|
---|---|
|
189
|
|
157
|
Accessibility
97.91%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
101
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 2 failed tests • app-e2e
src/runner/selector-playground/SelectorPlayground.cy.tsx • 1 failed test • app-ct
Test | Artifacts | |
---|---|---|
SelectorPlayground > shows copy tooltip when button is focused |
Test Replay
|
e2e/e2e_cookies.cy.js • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
e2e cookies spec > __Host- prefix > can set __Host- cookie |
Test Replay
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
Test | Artifacts | |||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
... > stops waiting when an xhr request is canceled |
|
Test | Artifacts | |||||||
---|---|---|---|---|---|---|---|---|
e2e cookies spec > __Host- prefix > can set __Host- cookie |
|
Test | Artifacts | |
---|---|---|
src/cy/commands/files > #readFile > retries to read when ENOENT |
The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud. |
* feat: cy prompt infrastructure * refactor and add tests * refactor * rename experimental config * prompt * fix test * Update cy-prompt-development.md * Update cy-prompt-development.md * PR comments * Update packages/server/lib/cloud/api/cy-prompt/get_cy_prompt_bundle.ts Co-authored-by: Copilot <[email protected]> * PR comments --------- Co-authored-by: Copilot <[email protected]>
* chore: add cdp connection to cy prompt * minor fix * fix type build * try to fix build * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <[email protected]> * Update packages/server/lib/browsers/browser-cri-client.ts Co-authored-by: Bill Glesias <[email protected]> * do not support prompt in firefox or webkit * rework timing of lifecycle * refactor * fix tests * troubleshooting * troubleshooting * fix tests * additional troubleshooting * additional troubleshooting * additional troubleshooting * attempt to fix build * add back * debugging * debugging * debugging * debugging * clean up * fix unit tests * rework --------- Co-authored-by: Bill Glesias <[email protected]>
…#31803) * chore: add promptBackend as an additional Cypress-attached function * Update packages/app/src/runner/event-manager.ts * update types * fix types * fix spacing * refactor * additional refactor * fix type build * fix build * refactor * reword messages * fix * debugging * undo debugging * PR comment * fix tests * fix tests * fix tests * fix test
* chore: add watcher for cy-prompt development * test caching * fix types
…31835) * internal: (cy.prompt) handle errors better in the command definition * internal: (cy.prompt) add timeout and handle loading errors more cleanly * add process environment variable * clean up test * update JSDoc
* chore: handle errors * Fix ts, add test * Fix error title * Fix ts * Fix ts
@@ -31,6 +31,7 @@ exports['module api and after:run results'] = ` | |||
"experimentalSourceRewriting": false, | |||
"experimentalSingleTabRunMode": false, | |||
"experimentalStudio": false, | |||
"experimentalPromptCommand": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was requested review as Code Owner due to the results API change here. This change looks good. 👍🏻
* share error utils with cloud * additional rework * Fix command, add isOpenMode * Add / fix test * fix ts --------- Co-authored-by: Ryan Manuel <[email protected]>
…31904) * chore: (cy.prompt) add infrastructure to support a Get Code modal * fix tests * fix code paths * Update eject button styles * handle errors * update types * Update packages/server/lib/socket-base.ts * Fix cy test * update readme --------- Co-authored-by: estrada9166 <[email protected]>
* chore: (cy.prompt) refactor getTestsState to take a runnable id * fix tests * minor tweak
…31922) * chore: (cy.prompt) add manifest for all of the cloud delivered files * fix tests and remove environment variables * update strategy * fix build * rework * require manifest * clean up * refactor * refactor * Update packages/server/lib/cloud/cy-prompt/CyPromptLifecycleManager.ts Co-authored-by: Matt Schile <[email protected]> * fix test --------- Co-authored-by: Matt Schile <[email protected]>
) * feat: (cy.prompt) give cy.prompt access to recording information * undo bad refactor * undo bad refactor * undo bad refactor * rename * fix typo * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js * Update packages/server/test/unit/modes/record_spec.js
ryanthemanuel
commented
Aug 6, 2025
ryanthemanuel
commented
Aug 6, 2025
…ng promises in parallel (#32196) * fix: (cy.prompt) improve the get project options performance by running promises in parallel * add awaits in test
ryanthemanuel
commented
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a merge commit for this PR
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?