Skip to content

Conversation

adamalston
Copy link
Contributor

Additional details

I left a TODO with some questions that hopefully someone can answer.

Steps to test

Revert the fix and check that the test fails.

How has the user experience changed?

N/A

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@adamalston
Copy link
Contributor Author

Regarding the changes in a623e1f:

  • The pre-commit hook would not pass without the update in packages/electron/lib/print-node-version.ts.
  • I did not make the change in npm/cypress-schematic/src/schematics/utils/index.ts. It appears to have been made automatically.
  • I did not move the changelog entry. I dont' seen any benefit in moving it and creating additional conflicts before the code is reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelled network requests fail to resolve with cy.wait
2 participants