Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Sep 9, 2025

  • Closes

Additional details

removes dependencies and files no longer needed as we have migrated off mocha to vitest. NOTE the mocha/chai types are still needed as we bundle them with the CLI

Removes files and dependencies no longer needed now that mocha tests have been replaced by vitest

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker self-assigned this Sep 9, 2025
Copy link

cypress bot commented Sep 10, 2025

cypress    Run #65448

Run Properties:  status check passed Passed #65448  •  git commit 46fbb11a42: chore: remove files no longer used now that mocha tests are converted to vitest
Project cypress
Branch Review chore/cli_mocha_cleanup
Run status status check passed Passed #65448
Run duration 16m 34s
Commit git commit 46fbb11a42: chore: remove files no longer used now that mocha tests are converted to vitest
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 132
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5583
View all changes introduced in this branch ↗︎

Base automatically changed from chore/cli_tests_tasks to feature/cli_to_vitest September 10, 2025 17:37
@AtofStryker AtofStryker force-pushed the chore/cli_mocha_cleanup branch from 50c67d7 to 46fbb11 Compare September 10, 2025 17:38
@@ -1,4 +0,0 @@
import Bluebird from 'bluebird'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 💯

@AtofStryker AtofStryker merged commit 590f0a0 into feature/cli_to_vitest Sep 12, 2025
88 of 90 checks passed
@AtofStryker AtofStryker deleted the chore/cli_mocha_cleanup branch September 12, 2025 16:53
AtofStryker added a commit that referenced this pull request Sep 12, 2025
* chore: rename snapshots and spec files to fit vitest convention (#32405)

* chore: move compiled files to dist directory to make vitest convertion easier (#32406)

* chore: convert utils to vitest (#32407)

* chore: convert logger to vitest

* chore: convert errors spec to vitest

* chore: convert cypress spec to vitest

* chore: convert `exec` directory to `vitest` (#32428)

* chore: cut over exec directory to vitest

* Update cli/test/lib/exec/run.spec.ts

* Update cli/test/lib/exec/run.spec.ts

* Update cli/test/lib/exec/run.spec.ts

* chore: convert the CLI and build script specs over to vitest (#32438)

* chore: convert tasks directory to vitest (#32434)

change way verify module is exported due to issues interpreting module (thinks its an esm)

rework scripts as we cannot run an empty mocha suite

chore: fix snapshots and verify requires that are internal to the cypress project

fix stubbing issues with fs-extra which is also used by request-progress under the hood

fix issues where xvfb was stopping prematurely

* chore: remove files no longer used now that mocha tests are converted to vitest (#32455)

* build binaries

* chore: fix CLI tests (#32484)

* chore: remove CI branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants