-
Notifications
You must be signed in to change notification settings - Fork 3.3k
chore: update tsx
to 4.20.5
#32469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tsx
to 4.20.5
#32469
Conversation
34a2bcb
to
9efe54d
Compare
cypress
|
Project |
cypress
|
Branch Review |
update-tsx
|
Run status |
|
Run duration | 19m 25s |
Commit |
|
Committer | Bill Glesias |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
10
|
|
1102
|
|
0
|
|
26662
|
View all changes introduced in this branch ↗︎ |
UI Coverage
44.99%
|
|
---|---|
|
187
|
|
157
|
Accessibility
97.71%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
110
|
c779a3e
to
885112b
Compare
885112b
to
aa8ae45
Compare
[email protected].5: | ||
version "4.20.5" | ||
resolved "https://registry.yarnpkg.com/tsx/-/tsx-4.20.5.tgz#856c8b2f114c50a9f4ae108126967a167f240dc7" | ||
integrity sha512-+wKjMNU9w/EaQayHXb7WA7ZaHY6hN8WgfvHNQ3t1PnU91/7O8TcTnIhCDYTZwnt8JsO9IBqZ30Ln1r7pPF52Aw== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Node Compatibility Issue with tsx
Upgrade
The PR's stated goal was to downgrade tsx
to 4.19.3
for Node 20.0.0 compatibility. Instead, tsx
is upgraded from 4.20.4
to 4.20.5
, and the Node engine requirement is updated to drop support for Node 20.0.0. This contradicts the intended fix and removes Node 20.0.0 compatibility rather than resolving it.
Additional Locations (3)
tsx
to 4.19.3
tsx
to 4.20.5
Additional details
There is an issue in Cypress
15.2.0
where specifically Node20.0.0
does not work in the binary. After tracking down the issue, it looks to be related to thetsx
update in #32063 when running the binary. This PR updates the version to4.20.5
and sets the node minimum for Node 20 to20.1.0
in the CLISteps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?