-
Notifications
You must be signed in to change notification settings - Fork 3.4k
internal: (studio) display cert error #32657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
approved these changes
Oct 6, 2025
cypress
|
Project |
cypress
|
Branch Review |
mschile/studio/show_cert_error
|
Run status |
|
Run duration | 11m 05s |
Commit |
|
Committer | Matthew Schile |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
1
|
|
0
|
|
683
|
View all changes introduced in this branch ↗︎ |
UI Coverage
37.68%
|
|
---|---|
|
129
|
|
78
|
Accessibility
97.37%
|
|
---|---|
|
3 critical
7 serious
1 moderate
1 minor
|
|
62
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Note
Adds cert-error detection to Studio lifecycle and GraphQL subscription, and shows a customized Studio error panel with Learn more and Retry; updates types, logging, and cy.prompt proxy message.
StudioErrorPanel.vue
now supportstitle
,message
,icon
, and optionallearnMoreUrl
; renders Learn more (opens viaeventManager.ws.emit('external:open')
) and Retry.StudioPanel.vue
computes cert-error UI whenisCertError
is true (usesIconCypressStudio
, proxy help URL) and passes props toStudioErrorPanel
.SpecRunnerOpenMode.vue
subscribes tostudioStatusChange { status, isCertError, canAccessStudioAI }
and passesisCertError
toStudioPanel
.StudioStatusPayload.isCertError
and include it instudioStatusChange
.INITIALIZED
fromStudioStatusType
andSTUDIO_STATUSES
.updateStatus(status, error?)
stores code (supportsAggregateError
).getIsCertError()
(checks cert error codes) and includeisCertError
in subscription whenIN_ERROR
.CERT_HAS_EXPIRED
.get_studio_bundle.ts
.promptProxyError
message; align e2e test.StudioPanel.cy.tsx
for cert-error view; updateStudioErrorPanel
tests; expand server unit tests for status, cert errors, and ENABLED state.@cypress-design/vue-icon
and icon registry versions.Written by Cursor Bugbot for commit 67a96ab. This will update automatically on new commits. Configure here.
Steps to test
Setup a proxy with a self-signed cert and run Cypress without the passing in the CA. Verify the cert error view is displayed in Studio.
How has the user experience changed?
Before:

After:

PR Tasks
cypress-documentation
?type definitions
?