Skip to content

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Oct 6, 2025

Additional details


Note

Adds cert-error detection to Studio lifecycle and GraphQL subscription, and shows a customized Studio error panel with Learn more and Retry; updates types, logging, and cy.prompt proxy message.

  • Studio UI:
    • Error Panel: StudioErrorPanel.vue now supports title, message, icon, and optional learnMoreUrl; renders Learn more (opens via eventManager.ws.emit('external:open')) and Retry.
    • Panel Behavior: StudioPanel.vue computes cert-error UI when isCertError is true (uses IconCypressStudio, proxy help URL) and passes props to StudioErrorPanel.
    • Runner Wiring: SpecRunnerOpenMode.vue subscribes to studioStatusChange { status, isCertError, canAccessStudioAI } and passes isCertError to StudioPanel.
  • GraphQL/Types:
    • Add StudioStatusPayload.isCertError and include it in studioStatusChange.
    • Remove INITIALIZED from StudioStatusType and STUDIO_STATUSES.
  • Server (StudioLifecycleManager):
    • Track last error code; updateStatus(status, error?) stores code (supports AggregateError).
    • Expose getIsCertError() (checks cert error codes) and include isCertError in subscription when IN_ERROR.
    • Always prepare protocol; add retry state reset for error code.
    • Cert error codes: add CERT_HAS_EXPIRED.
    • Add debug logs in get_studio_bundle.ts.
  • Driver:
    • Tweak promptProxyError message; align e2e test.
  • Tests:
    • New StudioPanel.cy.tsx for cert-error view; update StudioErrorPanel tests; expand server unit tests for status, cert errors, and ENABLED state.
  • Deps:
    • Bump @cypress-design/vue-icon and icon registry versions.

Written by Cursor Bugbot for commit 67a96ab. This will update automatically on new commits. Configure here.

Steps to test

Setup a proxy with a self-signed cert and run Cypress without the passing in the CA. Verify the cert error view is displayed in Studio.

How has the user experience changed?

Before:
Screenshot 2025-10-06 at 4 39 36 PM

After:
Screenshot 2025-10-06 at 4 35 18 PM

PR Tasks

@mschile mschile marked this pull request as ready for review October 6, 2025 22:34
cursor[bot]

This comment was marked as outdated.

@mschile mschile requested a review from ryanthemanuel October 6, 2025 22:41
Copy link

cypress bot commented Oct 7, 2025

cypress    Run #66255

Run Properties:  status check passed Passed #66255  •  git commit 67a96ab9cb: move learn more button
Project cypress
Branch Review mschile/studio/show_cert_error
Run status status check passed Passed #66255
Run duration 11m 05s
Commit git commit 67a96ab9cb: move learn more button
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 683
View all changes introduced in this branch ↗︎
UI Coverage  37.68%
  Untested elements 129  
  Tested elements 78  
Accessibility  97.37%
  Failed rules  3 critical   7 serious   1 moderate   1 minor
  Failed elements 62  

@mschile mschile merged commit 74bae64 into develop Oct 7, 2025
91 of 92 checks passed
@mschile mschile deleted the mschile/studio/show_cert_error branch October 7, 2025 16:07
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 7, 2025

Released in 15.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v15.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants