-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat: add toggle to hide fetch requests #32658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add toggle to hide fetch requests #32658
Conversation
cypress
|
Project |
cypress
|
Branch Review |
alejandro/chore/hide-fetch-requests
|
Run status |
|
Run duration | 20m 29s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
12
|
|
1102
|
|
4
|
|
26708
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.56%
|
|
---|---|
|
185
|
|
159
|
Accessibility
97.97%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
101
|
…o/chore/hide-fetch-requests
} | ||
} | ||
|
||
if (model.name === 'request' && !appState.showFetchRequests) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will hide cy.request
command logs as well (which I don't think we want). I think you just need to check model.event
is true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated here 894f856
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?Note
Introduces a user preference and UI toggle to hide/show HTTP (fetch/xhr) requests in the Command Log, wired through GraphQL/local settings, runner state, and reporter rendering with tests.
runnable-popover-options.tsx
).showFetchRequests
; request logs (command.tsx
) are hidden when disabled.preferences.showFetchRequests
(defaulttrue
) added to GraphQL schema (gql-LocalSettings.ts
,schema.graphql
) and types (preferences.ts
).showFetchRequests
plus toggle/set APIs; persisted viasave:state
and restored on start.showFetchRequests
throughSpecRunnerOpenMode.vue
,reporter.ts
,main.tsx
, andevent-manager.ts
(included inreporter:start
payload and saved viasave:state
).showFetchRequests
.Written by Cursor Bugbot for commit e7c9757. This will update automatically on new commits. Configure here.