Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 7, 2025

  • Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks


Note

Migrates launcher to async/await with no Bluebird, introduces dual CJS/ESM outputs, and updates server modes/tests and platform helpers accordingly.

  • Launcher (core refactor):
    • Move from Bluebird to native async/await Promises across lib/detect.ts, darwin, linux, windows.
    • Refactor lib/utils.ts: export spawnWithArch and getOutput (no utils wrapper); replace utils.execa with direct execa.
    • Update platform helpers: async detect, parsePlist, mdfind, version resolution and timeouts (Linux snap detection, getVersionString).
    • Internal dedupe now via uniqBy with name-version key in lib/detect.ts.
    • Entry/module structure: add lib/index.ts; remove root index.ts; switch package to dual build outputs (cjs/, esm/), set main, module, types.
    • Tooling: add tsconfig.cjs.json, tsconfig.esm.json; update tsconfig.json (strict, declarations); ignore cjs/ & esm/; remove bluebird dep.
  • Server (integration updates):
    • Convert startInMode paths for version, info, smokeTest, returnPkg, exitWithCode, run to async/await; inline pkg/info/exit logic (remove modes/pkg.ts, modes/exit.ts).
    • lib/modes/info.ts: export info async function; update usage in tests.
    • browsers/utils.ts: make ensureAndGetByNameOrPath async; handle launcher.detectByPath with try/catch.
  • Tests and snapshots:
    • System test browser_path_spec.js migrated to async/await; disable video in run; update snapshot (no video section, Video: false).

Written by Cursor Bugbot for commit ac1db0a. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker changed the title chore: refactor launcher chore (draft): refactor launcher Oct 7, 2025
@AtofStryker AtofStryker self-assigned this Oct 7, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Oct 7, 2025

cypress    Run #66277

Run Properties:  status check failed Failed #66277  •  git commit ac1db0a111: fix typing cast issue
Project cypress
Branch Review chore/refactor_launcher
Run status status check failed Failed #66277
Run duration 44m 17s
Commit git commit ac1db0a111: fix typing cast issue
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 10
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26688
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.4%
  Untested elements 185  
  Tested elements 158  
Accessibility  97.98%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 100  

Tests for review

Failed  studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > creates a new test from an empty spec Test Replay Screenshots
Failed  runner/cloud-debug-filter.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
cloud debug test filtering > filter is maintained across cross-domain reinitialization Test Replay Screenshots
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay

The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.

@AtofStryker AtofStryker force-pushed the chore/refactor_launcher branch from f176960 to cbdcae7 Compare October 7, 2025 14:39
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant