-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore (draft): refactor launcher #32660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AtofStryker
wants to merge
8
commits into
chore/launcher_vitest
Choose a base branch
from
chore/refactor_launcher
base: chore/launcher_vitest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+390
−314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
chore/refactor_launcher
|
Run status |
|
Run duration | 44m 17s |
Commit |
|
Committer | Bill Glesias |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
2
|
|
10
|
|
1102
|
|
4
|
|
26688
|
View all changes introduced in this branch ↗︎ |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.4%
|
|
---|---|
|
185
|
|
158
|
Accessibility
97.98%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
100
|
Tests for review
studio/studio.cy.ts • 1 failed test • app-e2e
Test | Artifacts | |
---|---|---|
Cypress Studio > creates a new test from an empty spec |
Test Replay
Screenshots
|
runner/cloud-debug-filter.cy.ts • 1 failed test • app-e2e
Test | Artifacts | |
---|---|---|
cloud debug test filtering > filter is maintained across cross-domain reinitialization |
Test Replay
Screenshots
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
Test | Artifacts | |
---|---|---|
issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome
Test | Artifacts | |
---|---|---|
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome
Test | Artifacts | |
---|---|---|
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
Test | Artifacts | |
---|---|---|
issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
The first 5 flaky specs are shown, see all 10 specs in Cypress Cloud.
f176960
to
cbdcae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?Note
Migrates launcher to async/await with no Bluebird, introduces dual CJS/ESM outputs, and updates server modes/tests and platform helpers accordingly.
lib/detect.ts
,darwin
,linux
,windows
.lib/utils.ts
: exportspawnWithArch
andgetOutput
(noutils
wrapper); replaceutils.execa
with directexeca
.detect
,parsePlist
,mdfind
, version resolution and timeouts (Linux snap detection,getVersionString
).uniqBy
withname-version
key inlib/detect.ts
.lib/index.ts
; remove rootindex.ts
; switch package to dual build outputs (cjs/
,esm/
), setmain
,module
,types
.tsconfig.cjs.json
,tsconfig.esm.json
; updatetsconfig.json
(strict, declarations); ignorecjs/
&esm/
; removebluebird
dep.startInMode
paths forversion
,info
,smokeTest
,returnPkg
,exitWithCode
,run
to async/await; inline pkg/info/exit logic (removemodes/pkg.ts
,modes/exit.ts
).lib/modes/info.ts
: exportinfo
async function; update usage in tests.browsers/utils.ts
: makeensureAndGetByNameOrPath
async; handlelauncher.detectByPath
with try/catch.browser_path_spec.js
migrated to async/await; disable video in run; update snapshot (no video section,Video: false
).Written by Cursor Bugbot for commit ac1db0a. This will update automatically on new commits. Configure here.