WIP: support Angular 21 inside @cypress/schematic
#33027
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/cypress-schematic-angular-21
|
| Run status |
|
| Run duration | 19m 02s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1097
|
Skipped
|
4
|
Passing
|
26703
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
Untested elements
|
188
|
|
Tested elements
|
161
|
Accessibility
98%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
AtofStryker
force-pushed
the
chore/cypress-schematic-angular-21
branch
from
b3e5b6a to
9a38f7c
Compare
| if (overwrite || !json.get(path)) { | ||
| json.modify(path, version) | ||
| // mock the correct binary here for now | ||
| json.modify(path, 'https://cdn.cypress.io/beta/npm/15.8.0/darwin-arm64/feat/add_zoneless_angular_harness-d64f6cf48ca1d64475a53a44e83c2d58cc627dd9/cypress.tgz') |
There was a problem hiding this comment.
Bug: Hardcoded beta binary URL replaces actual Cypress version
The addPackageJsonDependency function ignores the version parameter passed from the caller and hardcodes a specific beta CDN URL instead. When users run ng add @cypress/schematic, this causes Cypress to be installed from a specific feature branch beta build rather than the latest stable version from npm. The version variable is destructured but never used, as indicated by the @ts-expect-error comment acknowledging this should be removed. This appears to be debug code that was accidentally committed.
Additional Locations (1)
| const { projects } = angularJsonValue | ||
|
|
||
| // if using Angular 21 or greater, we need to use the cypress/angular-zoneless mount function | ||
| const applyPath = isSemverGte(options.__version__, '21.0.0') ? './files-ct-zoneless' : './files-ct' |
There was a problem hiding this comment.
Bug: Null version causes semver comparison to throw error
The isSemverGte(options.__version__, '21.0.0') call can throw a TypeError when options.__version__ is null. The getAngularSemverVersion function returns null when it can't parse the Angular version or when @angular/core isn't found in dependencies. The semver gte function throws when given null as the first argument rather than returning false. This would cause the schematic to crash for projects with unusual or missing Angular version specifications.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Introduces
@cypress/angular-zonelessand integrates Angular 21 zoneless component testing across CLI, schematics, scaffolding, tests, and CI.@cypress/angular-zonelesswithmount/createOutputSpyusing zoneless change detection.cypress/angular-zoneless, include in build copy, file lists, and ESLint ignores.@angular/core/rxjs-interopexternals and subscription cleanup; minor event subscription fix in@cypress/angular.@cypress/schematic):>=21scaffold zoneless CT support files and usecypress/angular-zonelessin support.semverdep; tests updated for Angular 20/21 and zoneless paths.cypressinstall URL in dependency writer.cypress/angular-zonelessfor Angular>=21, otherwisecypress/angular.angular-21fixture/project and specs using zoneless mount; adjust aliases and configs; separate Angular 21 run.styles.css).npm-angular-zonelessjob to workflows and ready-to-release deps; update branch filters; bump cache version.CONTRIBUTING.md.Written by Cursor Bugbot for commit 9a38f7c. This will update automatically on new commits. Configure here.