Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct baseUrl when running in non-public Github instances #1371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mungodewar
Copy link

@mungodewar mungodewar commented Feb 25, 2025

Issue?

When running the action against a non-public GH instance, the api request to determine build-id from Github would fail.

Bad Credentials

I believe this is due to the incorrect (public) GH instance being contacted.

How?

The fix uses:

@cypress-app-bot
Copy link

@mungodewar mungodewar marked this pull request as ready for review February 25, 2025 16:19
@MikeMcC399 MikeMcC399 added the bug Something isn't working label Feb 25, 2025
@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
All committers have signed the CLA.

@MikeMcC399
Copy link
Collaborator

@mungodewar

Thanks for describing your issue and suggesting a resolution!

When you refer to "non-public GitHub instances", do you mean a self-hosted runner in a GitHub Enterprise Server or perhaps GitHub Enterprise Cloud? I assume that you don't mean just a private repository using a GitHub-hosted runner.

The code you propose to change was added by the Cypress Cloud team, so I would expect that they should be involved in any changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cypress Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants