Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 28, 2025

  • Investigated failing CI checks
  • Identified spellcheck failures due to new submodule-related terminology
  • Added missing words to inst/WORDLIST (LaTeX, gitmodules, recurse, submodule, submodules)
  • Fixed spellcheck workflow configuration
Original prompt

This section details on the original issue you should resolve

<issue_title>extract my latex macros into a separate repo and use it here as a git submodule</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits December 28, 2025 01:21
- Created latex-macros/ directory with its own git repo
- Moved macros.qmd to latex-macros/macros.qmd
- Added .gitmodules file for submodule configuration
- Updated all 52 .qmd files to reference latex-macros/macros.qmd
- Removed old macros.qmd from root
- Added setup instructions in SUBMODULE_SETUP.md

Co-authored-by: d-morrison <[email protected]>
- Added submodules: recursive to preview.yml workflow
- Added submodules: recursive to publish.yml workflow
- Updated SUBMODULE_SETUP.md to reflect workflow changes

Co-authored-by: d-morrison <[email protected]>
- Added Getting Started section with git submodule clone instructions
- Added reference to SUBMODULE_SETUP.md for details

Co-authored-by: d-morrison <[email protected]>
Copilot AI changed the title [WIP] Extract LaTeX macros into a separate repository Extract LaTeX macros into separate repository as git submodule Dec 28, 2025
Copilot AI requested a review from d-morrison December 28, 2025 01:26
@d-morrison
Copy link
Owner

@copilot I want the new repo to be called macros

- Updated .gitmodules URL to d-morrison/macros
- Updated all references in SUBMODULE_SETUP.md

Co-authored-by: d-morrison <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 28, 2025

@copilot I want the new repo to be called macros

Done! Updated the repository name to macros in commit 918d03a. The .gitmodules and SUBMODULE_SETUP.md now reference https://github.com/d-morrison/macros.git.

@d-morrison
Copy link
Owner

import https://github.com/d-morrison/macros as a git submodule

@d-morrison
Copy link
Owner

@copilot import https://github.com/d-morrison/macros as a git submodule

- Initialized latex-macros submodule from https://github.com/d-morrison/macros.git
- Updated submodule reference to commit 902bab8 (latest from remote)
- Submodule now properly tracks the remote repository

Co-authored-by: d-morrison <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 28, 2025

@copilot import https://github.com/d-morrison/macros as a git submodule

Done! The submodule has been imported from https://github.com/d-morrison/macros in commit 722ac1a. The latex-macros directory now properly tracks the remote repository at commit 902bab8.

- Marked setup as complete
- Updated documentation to show current status
- Removed setup instructions since submodule is now configured

Co-authored-by: d-morrison <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

PR Preview Action v1.7.2

🚀 View preview at
https://d-morrison.github.io/rme/pr-preview/pr-305/

Built to branch gh-pages at 2025-12-28 08:02 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@d-morrison
Copy link
Owner

@copilot fix failing checks

Copy link
Contributor Author

Copilot AI commented Dec 28, 2025

@copilot fix failing checks

Fixed in commit 5b3532e. The check-spelling.yaml workflow was missing the submodules: recursive configuration in the checkout step, which prevented it from accessing the macros.qmd file in the latex-macros submodule.

Copy link
Owner

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix checks

- Added LaTeX, gitmodules, recurse, submodule, submodules to inst/WORDLIST
- Fixes spellcheck failures from new documentation

Co-authored-by: d-morrison <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 28, 2025

fix checks

Fixed in commit 1a34c02. The spellcheck was failing because new terminology (LaTeX, gitmodules, recurse, submodule, submodules) wasn't in the WORDLIST. Added these words to inst/WORDLIST.

Copilot AI requested a review from d-morrison December 28, 2025 06:33
@d-morrison d-morrison marked this pull request as ready for review December 28, 2025 08:42
Copilot AI review requested due to automatic review settings December 28, 2025 08:42
@d-morrison d-morrison merged commit 50ed22a into main Dec 28, 2025
2 of 3 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extracts LaTeX macros from the repository into a separate git submodule to enable reuse across multiple projects. The change relocates the macros.qmd file to a dedicated repository (https://github.com/d-morrison/macros.git) and references it as a git submodule at latex-macros/.

Key changes:

  • Moved LaTeX macros to external repository as git submodule
  • Updated all 52 .qmd file includes to reference latex-macros/macros.qmd
  • Configured GitHub Actions workflows to recursively checkout submodules
  • Added documentation for cloning and updating the submodule

Reviewed changes

Copilot reviewed 61 out of 61 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.gitmodules Defines the new latex-macros submodule configuration
latex-macros Git submodule reference pointing to commit 902bab8
macros.qmd Removed (moved to submodule repository)
shared-config.qmd, notation.qmd, etc. (52 files) Updated include paths from macros.qmd to latex-macros/macros.qmd
.github/workflows/*.yml Added submodules: recursive to checkout actions
inst/WORDLIST Added submodule-related terms for spellcheck
SUBMODULE_SETUP.md New documentation for submodule setup and usage
README.Rmd Added getting started section with submodule instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extract my latex macros into a separate repo and use it here as a git submodule

2 participants