Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lint-staged): windowsでも、特定のファイルに対して特定のリンターの実行が除外できるように修正 #176

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

arktds
Copy link
Contributor

@arktds arktds commented Aug 28, 2024

No description provided.

}
return path.isAbsolute(p) ? p : path.resolve(baseDir, p);
});
console.log({ targetFiles, absIgnorePatterns });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log({ targetFiles, absIgnorePatterns });

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.logの削除お願いします

@arktds arktds force-pushed the feature/fix-test-lint-staged-config branch from cbf4147 to 09bad00 Compare September 24, 2024 14:22
@arktds arktds force-pushed the feature/fix-test-lint-staged-config branch from 09bad00 to 65fc979 Compare September 24, 2024 14:24
@arktds arktds marked this pull request as ready for review September 24, 2024 14:26
@arktds
Copy link
Contributor Author

arktds commented Sep 24, 2024

@YusukeHirao
GitHub Actions のテスト結果を確認するため WIP としてドラフトプルリクエストにしていましたが、現状で問題なさそうなので、コミットをスカッシュ&フォースプッシュしました。
2度目のフォースプッシュはコミットメッセージを修正するためです。
(Squash and Merge でも良かったかもしれません。)

レビューお願いいたします!

@YusukeHirao YusukeHirao merged commit 486ec17 into dev Sep 25, 2024
2 checks passed
@YusukeHirao YusukeHirao deleted the feature/fix-test-lint-staged-config branch September 25, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants