Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locale file for zh-TW #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add locale file for zh-TW #131

wants to merge 1 commit into from

Conversation

minaseem
Copy link

This is in reference to the issue #130

Added a locale file for zh-TW.

References:
https://en.wikipedia.org/wiki/Decimal_separator#Digit_grouping
https://en.wikipedia.org/wiki/New_Taiwan_dollar

@minaseem
Copy link
Author

I could not understand the release model. Please let me know if I need to make any modifications to the PR.

@minaseem
Copy link
Author

minaseem commented Oct 3, 2022

@Fil By when can we merge and release this PR?

@minaseem
Copy link
Author

@Fil By when can we merge and release this PR?

I am looking forward to the release of this PR. Can I get a tentative plan?

cc: @Fil

@minaseem
Copy link
Author

Please let me know if I can help in anyway wrt to this PR

@minaseem
Copy link
Author

@Fil Do you have an update on plan for merging this PR?

@Fil Fil mentioned this pull request Mar 17, 2023
@minaseem
Copy link
Author

minaseem commented Jun 21, 2023

@Fil Is this package still under maintenance? If yes, Do you have a release cycle? Can you provide a clear direction on when this PR will get merged?

@lreis
Copy link

lreis commented Aug 23, 2023

@Fil @mbostock would you be able to assist in the merging of this PR and publishing a new release? We also support zh-TW in our products, and need this. Thank you.

@mbostock
Copy link
Member

You can host these locale files yourselves. There’s no need to be blocked on this PR being merged.

@lreis
Copy link

lreis commented Aug 23, 2023

@mbostock is this library still actively maintained?

@mbostock
Copy link
Member

Yes, I am still maintaining this library, for whatever that means. But there is no guarantee of when I will merge this PR, or a release schedule, etc. This is a free open-source library and you are free to fork the library if you wish.

Also, JavaScript support for internationalized formatting has much improved since this library was first created, so you are probably better off using the built-in Intl.NumberFormat rather than relying on the locale files here.

@lreis
Copy link

lreis commented Aug 24, 2023

@mbostock understood, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants