-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge WinUI3 extensions #507
base: master
Are you sure you want to change the base?
Conversation
Add temporary ReSharper configs. Update Target Frameworks. Add Release Notes. Co-Authored-By: David Hall <[email protected]>
Merge as of 22.01.2015
🚶 Coming soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to delete
- TargetFrameworks net5.0-windows
Delete .idea/.idea.Vanara/.idea/vcs.xml
@dahall One question, when pushing a integration test version of WinUI package, will it be included in the nightly AppVoyer build when the merge is still in progress? I guess not, or will it? Regards, tajbender |
I don't think so. Also, I have migrated away from AppVeyor and now use GitHub Actions to build after each commit and then post to MyGet. |
That's fine for me. I'm asking cause I crashed my dev setup for any reason, nowadays i am not even able to compile my last revisions I checked in 🐞 on the current Win 11 Insider / Visual Studio. However, I restarted from scratch with the latest iterations of Win App SDK with focus on I use some of their components within the codebase, but I guess you don't want such dependencies for Vanara. That's - however - not a show-stopper. I just would copy & paste i.e. import their classes into the package itself. There`re not that much classes I use, but I use some especially for performance reasons. @dahall Is that okay to you? |
This all sounds good. I stay holding until I hear you are ready to integrate. |
Thanks for your patience. I won't touch any other packages, nor do I need to for that stuff. I'm living on the WinUI package island solely 😃 It's completely decoupled from the existing Vanara code base, I just use your Shell stuff. The biggest Issue will be that namespaces and classes don't collide - beside code quality, for sure. |
Curious to have you try the 4.1.0 packages. I added .net 9.0 support and removed 4.5. Most notable is that all handles are now generated. I'm trying my hand at generation before using in many more places and maybe even pulling in generated code from https://github.com/microsoft/win32metadata to recreate Vanara live like CsWin32, but with the Vanara primitives and design goals. |
Thank you so much. Without doubt, the next days I finally will submit code. As mentioned yesterday, NETSDK1138: The target framework 'net7.0-windows10.0.19041.0' is out of support.. made me crazy for weeks now, cause every then and when this error came and left, and I don't get the point. Then I tried JetBrains Rider, and that beast doesn't even mention there could be a problem and compiles fine. I'm definitely too old for this 💩 - But I'm fine with the lessons learned, another year, another try 🧨. Now, I switched my dev-branch to reconfigure from scratch and ignore the .net7 issue. The XAML is already in, code stubs are coming. Everything works and compiles without this solely 'issue', but I don't even think it is one. Long writing, short story: Now comes the fun part again, writing code 🎃 |
@dahall Surprise! I'm very happy to let you know that we'll not only have a full working clone of |
This comment was marked as outdated.
This comment was marked as outdated.
fyi, I'm taking the direct route 🫖 |
Backtracking: WinUI 3 official Requirement:
|
🚶 Coming soon.