Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge WinUI3 extensions #507

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tajbender
Copy link
Contributor

@tajbender tajbender commented Feb 9, 2025

🚶 Coming soon.

⚠️ Work in Progress

tajbender and others added 2 commits December 28, 2024 04:21
Add temporary ReSharper configs.
Update Target Frameworks.
Add Release Notes.

Co-Authored-By: David Hall <[email protected]>
Merge as of 22.01.2015
@tajbender tajbender closed this Feb 9, 2025
@tajbender tajbender reopened this Feb 9, 2025
@tajbender tajbender changed the title Merge Win UI.extensions Merge WinUI3 extensions Feb 9, 2025
@tajbender tajbender marked this pull request as draft February 9, 2025 14:06
@tajbender
Copy link
Contributor Author

🚶 Coming soon.

⚠️ Work in Progress

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to delete

  • TargetFrameworks net5.0-windows

@tajbender
Copy link
Contributor Author

tajbender commented Feb 22, 2025

@dahall One question, when pushing a integration test version of WinUI package, will it be included in the nightly AppVoyer build when the merge is still in progress?

I guess not, or will it?

Regards, tajbender

@dahall
Copy link
Owner

dahall commented Feb 23, 2025

@dahall One question, when pushing a integration test version of WinUI package, will it be included in the nightly AppVoyer build when the merge is still in progress?

I don't think so. Also, I have migrated away from AppVeyor and now use GitHub Actions to build after each commit and then post to MyGet.

@tajbender
Copy link
Contributor Author

tajbender commented Feb 24, 2025

I don't think so. Also, I have migrated away from AppVeyor and now use GitHub Actions to build after each commit and then post to MyGet.

That's fine for me. I'm asking cause I crashed my dev setup for any reason, nowadays i am not even able to compile my last revisions I checked in 🐞 on the current Win 11 Insider / Visual Studio.

However, I restarted from scratch with the latest iterations of Win App SDK with focus on ExplorerBrowser control alone. Another question is targeting the Windows Community Toolkit.

I use some of their components within the codebase, but I guess you don't want such dependencies for Vanara. That's - however - not a show-stopper. I just would copy & paste i.e. import their classes into the package itself. There`re not that much classes I use, but I use some especially for performance reasons.

e.g.: https://github.com/CommunityToolkit/Windows/tree/main/components/Collections/src/AdvancedCollectionView

@dahall Is that okay to you?

@dahall
Copy link
Owner

dahall commented Feb 26, 2025

@dahall Is that okay to you?

This all sounds good. I stay holding until I hear you are ready to integrate.

@tajbender
Copy link
Contributor Author

Thanks for your patience. I won't touch any other packages, nor do I need to for that stuff.

I'm living on the WinUI package island solely 😃 It's completely decoupled from the existing Vanara code base, I just use your Shell stuff.

The biggest Issue will be that namespaces and classes don't collide - beside code quality, for sure.

@dahall
Copy link
Owner

dahall commented Mar 7, 2025

Curious to have you try the 4.1.0 packages. I added .net 9.0 support and removed 4.5. Most notable is that all handles are now generated. I'm trying my hand at generation before using in many more places and maybe even pulling in generated code from https://github.com/microsoft/win32metadata to recreate Vanara live like CsWin32, but with the Vanara primitives and design goals.

@tajbender
Copy link
Contributor Author

Thank you so much. Without doubt, the next days I finally will submit code.

As mentioned yesterday, NETSDK1138: The target framework 'net7.0-windows10.0.19041.0' is out of support.. made me crazy for weeks now, cause every then and when this error came and left, and I don't get the point.

Then I tried JetBrains Rider, and that beast doesn't even mention there could be a problem and compiles fine.

I'm definitely too old for this 💩 - But I'm fine with the lessons learned, another year, another try 🧨. Now, I switched my dev-branch to reconfigure from scratch and ignore the .net7 issue. The XAML is already in, code stubs are coming. Everything works and compiles without this solely 'issue', but I don't even think it is one.

Long writing, short story: Now comes the fun part again, writing code 🎃

@tajbender
Copy link
Contributor Author

@dahall Surprise!

I'm very happy to let you know that we'll not only have a full working clone of ExplorerBrowser, it will also add double pane mode by default, without any hassle 🎈

image

@tajbender

This comment was marked as outdated.

@tajbender
Copy link
Contributor Author

tajbender commented Mar 9, 2025

Curious to have you try the 4.1.0 packages. I added .net 9.0 support and removed 4.5. Most notable is that all handles are now generated. I'm trying my hand at generation before using in many more places and maybe even pulling in generated code from https://github.com/microsoft/win32metadata to recreate Vanara live like CsWin32, but with the Vanara primitives and design goals.

fyi, I'm taking the direct route 🫖

image

electrifier/electrifier-v1.25@67417ed

@tajbender
Copy link
Contributor Author

tajbender commented Mar 10, 2025

Backtracking: WinUI 3 official Requirement:

Okay, I found the requirements: https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/system-requirements

The Windows App SDK has the following minimum system requirements:

  • Windows 10, version 1809 (build 17763) or later.
  • Visual Studio 2022, version 17.0 or later, with the required workloads and components.
  • Visual Studio 2019, version 16.9 or later, with the required workloads and components.
  • Windows SDK, version 2004 (build 19041) or later (included with Visual Studio 2019 and 2022 by default).
  • If you plan to build .NET apps, you'll also need .NET 6 or later (see Download .NET).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants