Modernize Ruby, Fluentd support and CI#8
Merged
Merged
Conversation
- Require Ruby >= 3.2, drop bundler version pin, bump rake to 13.x - Require fluentd >= 1.0, < 2; drop v0.14 from supported range - Bump version to 0.4.0 - Replace defunct wercker CI with GitHub Actions matrix (Ruby 3.2-4.0) - Move `require 'fluent/plugin/filter'` and `require 'addressable/uri'` to file top so plugins load standalone - Modernize test/helper.rb (drop rubygems/Bundler.setup/nulllogger, include Fluent::Test::Helpers) - Add tests for emit_invalid_record_to_error, parse error swallowing, and suppress_parse_error_log Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialize)suppress_parse_error_logChanges
Dependencies / metadata
required_ruby_version = ">= 3.2"fluentdconstraint:>= 0.14.0, < 2→>= 1.0, < 2bundler ~> 1.11→ unpinned,rake ~> 10.0→~> 13.0, pintest-unit ~> 3.6CI
wercker.yml(service shut down).github/workflows/test.ymlwithruby/setup-ruby@v1+bundler-cachePlugin code (filter_uri_parser.rb / filter_query_string_parser.rb)
require 'fluent/plugin/filter'andrequire 'addressable/uri'at file topinitialize(only calledsuperand lazy-required addressable)Tests
test/helper.rb: droprequire 'rubygems', dropBundler.setupguard, drop nulllogger pattern, includeFluent::Test::Helpersevent_time("...")helper instead ofFluent::EventTime.from_time(Time.parse(...))test_filter_emit_invalid_record_to_error_on_missing_keytest_filter_parse_error_is_swallowedtest_filter_suppress_parse_error_logTest plan
bundle exec rake teston Ruby 3.3 — 17 tests / 77 assertions / 0 failuresruby -Ilib -rfluent/plugin/filter_uri_parser)🤖 Generated with Claude Code