Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: uniform post page login #4046

Merged
merged 27 commits into from
Jan 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3747050
redirect on social click
AmarTrebinjac Jan 6, 2025
b5ea268
handle email case
AmarTrebinjac Jan 6, 2025
83c768f
add logic for banner as well
AmarTrebinjac Jan 6, 2025
850e9ad
linting memes
AmarTrebinjac Jan 6, 2025
b8fa471
Merge branch 'main' into MI-696
AmarTrebinjac Jan 6, 2025
585d762
lint
AmarTrebinjac Jan 6, 2025
49ca5c5
linter decided to not work anymore :)
AmarTrebinjac Jan 6, 2025
9d1bcab
update loginbutton test
AmarTrebinjac Jan 6, 2025
6f86e2e
update trigger type
AmarTrebinjac Jan 6, 2025
f868195
import as type
AmarTrebinjac Jan 6, 2025
78c0eb4
Merge branch 'main' into MI-696
AmarTrebinjac Jan 7, 2025
7a9a3c3
Merge branch 'main' into MI-696
AmarTrebinjac Jan 16, 2025
a5699c1
Merge branch 'main' into MI-696
AmarTrebinjac Jan 18, 2025
d56e3cd
keep old params
AmarTrebinjac Jan 18, 2025
a50ef4a
delete authmodal
AmarTrebinjac Jan 18, 2025
dd57779
useAuthContext
AmarTrebinjac Jan 20, 2025
ff3fac6
Merge branch 'main' into MI-696
AmarTrebinjac Jan 20, 2025
1ca32d1
Merge branch 'main' into MI-696
AmarTrebinjac Jan 21, 2025
a34d028
refactor showLogin
AmarTrebinjac Jan 21, 2025
ebfe354
add after auth param key
AmarTrebinjac Jan 21, 2025
96c482f
remove toString on params
AmarTrebinjac Jan 21, 2025
1d8c0cd
Merge branch 'main' into MI-696
AmarTrebinjac Jan 21, 2025
0998583
remove auth trigger param from onboarding
AmarTrebinjac Jan 21, 2025
9997cde
redirect correclty to signin page
AmarTrebinjac Jan 21, 2025
333771f
update test
AmarTrebinjac Jan 21, 2025
382d5c3
Merge branch 'main' into MI-696
AmarTrebinjac Jan 22, 2025
f275c6d
lint
AmarTrebinjac Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test
AmarTrebinjac committed Jan 21, 2025

Verified

This commit was signed with the committer’s verified signature.
AmarTrebinjac Amar Trebinjac
commit 333771f2b142da8a884e3b79a35dc592e271ad42
6 changes: 6 additions & 0 deletions packages/shared/src/components/LoginButton.spec.tsx
Original file line number Diff line number Diff line change
@@ -48,6 +48,9 @@ describe('LoginButton', () => {

expect(showLogin).toHaveBeenCalledWith({
trigger: AuthTriggers.MainButton,
options: {
isLogin: true,
},
});
});

@@ -62,6 +65,9 @@ describe('LoginButton', () => {

expect(showLogin).toHaveBeenCalledWith({
trigger: AuthTriggers.MainButton,
options: {
isLogin: false,
},
});
});
});