-
Notifications
You must be signed in to change notification settings - Fork 269
feat: add new briefing entry points and generate page #4780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…brief-free-entrypoints
The latest updates on your projects. Learn more about Vercel for GitHub.
|
export const BriefPlusUpgradeCTA = ({ | ||
className, | ||
...attrs | ||
}: ButtonProps<'a'> | undefined): ReactElement => { | ||
const { isAuthReady } = useAuthContext(); | ||
const { logSubscriptionEvent, isPlus } = usePlusSubscription(); | ||
const { | ||
value: { full: plusCta }, | ||
} = useConditionalFeature({ | ||
feature: featurePlusCtaCopy, | ||
shouldEvaluate: !isPlus && isAuthReady, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reused the actual Button component because this one has custom style.
Actually extracted this from old /briefing
page
…d updated briefing generation page
packages/shared/src/components/cards/brief/BriefCard/BriefCardDefault.tsx
Show resolved
Hide resolved
…ed BriefUpgradeAlert component
…brief-free-entrypoints
…v/apps into MI-969-brief-free-entrypoints
…nto MI-969-brief-free-entrypoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, besides the URL one nothing blocking.
Can youn maybe just failsafe build extension locally to see it doesn't break anything?
packages/shared/src/features/briefing/components/BriefPayForGenerateCard.tsx
Outdated
Show resolved
Hide resolved
…ilydotdev/apps into MI-969-brief-free-entrypoints# Inserisci un messaggio di commit per spiegare perché è necessario
Changes
Added new entry points and generate page. This will allow non-Plus users to access presidential briefing features.
Events
Added new events:
Experiment
Did you introduce any new experiments?
Feed entry point:
Name:
brief_feed_entrypoint_page
Value:
false
|number
Generation pricing
Name:
brief_generate_pricing
Value:
{ daily: 300, weekly: 500 }
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Jira ticket
MI-969
Preview domain
https://mi-969-brief-free-entrypoints.preview.app.daily.dev