Remove Axis.ordering
#53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madig
reviewed
Nov 21, 2025
src/statmake/classes.py
Outdated
| ) -> "Stylespace": | ||
| """Construct Stylespace from unstructured dict data.""" | ||
|
|
||
| def axis_hook(data: dict[str, Any], cls: type[Axis]) -> Axis: |
Collaborator
There was a problem hiding this comment.
Not fixed by from __future__ import annotations?
Member
Author
There was a problem hiding this comment.
Could have been, but this is more in-keeping with the existing code style. I'll probably squash away that commit entirely
RickyDaMa
force-pushed
the
remove-axis-ordering
branch
from
627dad9 to
20393b8
Compare
madig
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interally we've found this field too error-prone and not ultimately necessary when you can just re-order axes within the file.
First two commits mark the field as deprecated, suitable for a v1.1.1 patch release, before then removing the field entirely for a v2 breaking change