-
Notifications
You must be signed in to change notification settings - Fork 49
Use OS Secure Store for nsec #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
how do i test this on linux? |
run it, add an nsec, look at |
|
works with linux now & rebased with master |
|
I removed prior keys from the folder above using rm rf, and confirming via ls. I ran cargo run --release, and found a newly created key in the same folder above on Linux. |
|
In the newly created file in .../accounts it is a npub, so the PR checks out 💪. Confirming I was able to post a note to nostr with this PR checked out https://nostr.eu/nevent1qqsdprsuyz4t76ecnsar3d3xjgd25dxy8rjfy30appsntzq5zntznqczyrrmal6g449683c9se37res6ug3z354df299eue63tnjcj2ml0etcevll2f |
|
confirmed via the following command I stored to Linux keyring: to install on linux I used |
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
Signed-off-by: kernelkind <[email protected]>
fixes: > i opened up notedeck with the keyring branch and it seemed to > nuke my acocunt Signed-off-by: kernelkind <[email protected]>
Tested with MacOS & android. Need to test with linux & windows still
Run
adb shell 'run-as com.damus.notedeck ls -la /data/user/0/com.damus.notedeck/files/storage/accounts'and observe nsec getting turned into pubkey, but you remain logged in as nsec.This implementation migrates nsec values from plain files into the secure store while keeping the user logged in.