fix: separate "(binary file)" suffix from filename in hyperlinks #2075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I noticed a small issue with hyperlinks when viewing diffs of binary files. When
--hyperlinksis enabled, binary files show a suffix(binary file)in their filename. However, this suffix was being included as part of the filename in the hyperlink, making the links point to non-existent paths.For example, a binary file named
logo.pngwould generate a hyperlink tologo.png (binary file)instead of justlogo.png. This makes the link unusable since that exact path doesn't exist in the repository.Solution
I've fixed this by:
binary_filesflag to track binary status separately(binary file)indicator after the hyperlink is createdThis ensures hyperlinks point to the actual file paths while still clearly indicating they're binary files.
This is my first contribution to a Rust project, and I'm excited to help improve delta! I'd appreciate any feedback on the implementation. Thanks for creating such an incredible tool that makes my daily development work so much better! 🚀