Skip to content

make #headers public on CsvBuilder #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzfolio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make #headers public on CsvBuilder #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/as_csv/csv_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ def to_csv
rows.collect { |row| CSV.generate_line(row, **csv_options) }.join
end

def headers
@headers ||= csv_hashes.collect(&:keys).flatten.uniq
end

private

def rows
@rows ||= [headers] + data_rows
end

def headers
@headers ||= csv_hashes.collect(&:keys).flatten.uniq
end

def data_rows
@data_rows ||= csv_hashes.collect { |csv_hash| data_row csv_hash }
end
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/csv_builder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
end
end

context 'with hetreogenous records' do
context 'with heterogeneous records' do
Copy link
Owner

@danielfone danielfone Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

let(:records) do
2.times.map do |i|
double(:foo, :as_csv => {
Expand Down