Skip to content

Conversation

woodruffw
Copy link
Contributor

Summary

Follows #551. This currently fails, as expected, since dump() is not correctly specialized for Struct.

This is a work in progress.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@woodruffw
Copy link
Contributor Author

Just to post a brief update: per #551 (comment) and below, I don't yet have a great idea for a patch here. The basic thing that needs to happen is that dump() and load() need to be specialized for Struct, but doing so is weird because Struct is not referentially transparent against the underlying map<string, ...> type it contains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant